Re: [PATCH v6 0/3] Generic IOMMU pooled allocator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
Date: Tue, 24 Mar 2015 13:10:27 -0400

> Deltas from patchv5:
> - removed iommu_tbl_ops, and instead pass the ->flush_all as
>   an indirection to iommu_tbl_pool_init()
> - only invoke ->flush_all when there is no large_pool, based on
>   the assumption that large-pool usage is infrequently encountered.

Generally this looks fine to me.

But about patch #2, I see no reason to have multiple iommu_pool_hash
tables.  Even from a purely sparc perspective, we can always just do
with just one of them.

Furthermore, you can even probably move it down into lib/iommu-common.c
itself.  iommu_tbl_pool_init() can do the one time initialization.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux