From: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx> Date: Tue, 10 Mar 2015 18:27:03 -0400 > +#define IOMMU_ERROR_CODE (~(dma_addr_t)0x0) The value 'DMA_ERROR_CODE' is the only portable way to signal an error through a routine the returns DMA addresses. Please use that instead of inventing your own thing here. > + u32 page_table_map_base; > + u32 page_table_shift; These should be "unsigned long", which will increase powerpc's ability to share this code as their it_offset et al. are of this type. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html