Re: [PATCH v2 0/2] sparc: IOMMU pools for better scalability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>
Date: Tue, 3 Mar 2015 09:22:02 -0500

> 
> V2 version ofthis patch-set incorporates the feedback from
>   http://marc.info/?l=linux-sparc&m=142527471211108&w=2
> The sparc specific fields have been moved  off into iommu_64.h, 
> into struct iommu_sparc, leaving a minimalist struct iommu_table
> in the common functions..

Still have some sparc specific stuff in the generic header file.

For example, IOMMU_NUM_CTXS.

I don't see anything using cookie_to_index.

Furthermore, who so many TABS in the dma_4v_iommu_ops initializer?

Next, canonically "linux/" headers are included before "asm/" ones.

Please don't put "ifdef notyet" kind of stuff into your changes,
that is not appropriate.  In any event, I want you to translate all
of the PCI DMA implementations, because it is the only way you can
show me that your abstractions are sufficient.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux