From: Michal Hocko <mhocko@xxxxxxx> Date: Mon, 2 Mar 2015 21:33:04 +0100 > On Mon 02-03-15 15:04:05, David S. Miller wrote: >> From: Michal Hocko <mhocko@xxxxxxx> >> Date: Mon, 2 Mar 2015 14:54:42 +0100 >> >> > mdesc_kmalloc is currently requiring __GFP_NOFAIL allocation although it >> > seems that the allocation failure is handled by all callers (via >> > mdesc_alloc). __GFP_NOFAIL is a strong liability for the memory >> > allocator and so the users are discouraged to use the flag unless the >> > allocation failure is really a nogo. Drop the flag here as this doesn't >> > seem to be the case. >> > >> > Signed-off-by: Michal Hocko <mhocko@xxxxxxx> >> >> It is a serious failure. >> >> If we miss an MDESC update due to this allocation failure, the update >> is not an event which gets retransmitted so we will lose the updated >> machine description forever. >> >> We really need this allocation to succeed. > > OK, thanks for the clarification. This wasn't clear from the commit > which has introduced this code. I will drop this patch. Would you > accept something like the following instead? Sure. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
