Re: [PATCH] sunvdc: don't dereference port->disk before disk probe finishes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Dwight Engen <dwight.engen@xxxxxxxxxx>
Date: Tue, 27 Jan 2015 12:51:52 -0500

> If the backing file for a vdisk is not present in the service domain an
> ldc reset can occur during the initial port/disk probing. The ldc reset
> logic was dereferencing port->disk, which may not have been setup yet.
> Guard against this case.
> 
> Orabug: 20362258
> 
> Signed-off-by: Dwight Engen <dwight.engen@xxxxxxxxxx>
 ...
> @@ -938,6 +938,8 @@ err_out_free_tx_ring:
>  	vdc_free_tx_ring(port);
>  
>  err_out_free_ldc:
> +	flush_work(&port->ldc_reset_work);
> +	del_timer_sync(&port->ldc_reset_timer);
>  	vio_ldc_free(&port->vio);

This hunk has absolutely nothing to do with the bug you claim
to be fixing in your commit message, and needs to be split out
into a separate fix where you explain why these two calls are
necessary and exactly what the change is fixing.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux