>-----Original Message----- >From: linux-nics-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:linux-nics-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of >Sowmini Varadhan >Sent: Friday, January 09, 2015 7:21 AM >To: David Miller >Cc: e1000-devel@xxxxxxxxxxxxxxxxxxxxx; sparclinux@xxxxxxxxxxxxxxx; Linux NICS >Subject: [linux-nics] Solved: Re: ixgbe/linux/sparc perf issues >> From: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx> >> Date: Thu, 11 Dec 2014 14:45:42 -0500 >> I'm looking at an iperf issue running over ixgbe on linux >> on a sparc T5-2 platform (64 cpu) where we cannot get to line-speed >> (peaks at 3 Gbps on a 10Gbps link) and I'm trying to get to the bottom >> of this. > >On (12/11/14 15:09), David Miller replied: >davem> The real overhead is unavoidable due to the way the hypervisor access >davem> to the IOMMU is implemented in sun4v. > : >davem> I've known about this issue for a decade and I do not think there is >davem> anything we can really do about this. > >Not so. > >The HV implementation can handle 1 (maybe even 2) NIC ports per >socket on a T5-2 without needing any additional DMA optimizations. > >The real problem is that the ixgbe driver (and probably a few other >related drivers?) turns off relaxed-ordering during startup (not >sure why) and never turns it back on. Relaxed ordering is disabled by default at init and the driver only enables it for reads when DCA is used, which I suppose is not the case for you since you are on sparc. >The absence of relaxed-ordering is a serous serialization point, >and is responsible for throttling throughput down to 3 Gbps. > >After I hack things as shown in the patch below, I am able to easily >get 9-9.5 Gbps. (The only other patch needed is the iommu lock-break-up: >http://www.spinics.net/lists/sparclinux/msg13238.html) > >Perhaps someone in e1000-devel/linux.nics can provide some background >here on when this really needs to be turned off, and where to turn it back >on cleanly. Relaxed ordering was disabled due to an issue with some chipsets. There is a comment to that effect when enabling relaxed ordering for reads in ixgbe_update_tx_dca(). This was done back in 2011, so I'm still trying to dig through the details. >I'm sure there are more drivers than ixgbe that have this crippling bug. As I mentioned above it is intentional. I guess it makes sense to have it enabled for chipsets where it helps with performance, but I'm not sure what the criteria should be. In your patch below you enable relaxed ordering for writes - have you tested if there is any effect if you enable it only for reads or both? >there is another oddity that 'lspci -vv' reports RlxOrd as enabled, >even though this is clearly not the case, but that's a secondary issue. According to the docs - the IXGBE_DCA registers control R/W relaxed ordering per-queue. There is another register (IXGBE_CTRL_EXT - 0x018) that seems to enable/disable relaxed ordering for the device which could be why you are seeing the RlxOrd bit set, although I can't be sure. Thanks, Emil --Sowmini -----------patch follows below --------------------------------------------- diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c index 9c66bab..4453d92 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c @@ -338,6 +338,26 @@ s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw) return 0; } +void ixgbe_enable_relaxed_ordering(struct ixgbe_hw *hw) +{ + u32 i; + u32 regval; + + /* Enable relaxed ordering */ + for (i = 0; i < hw->mac.max_tx_queues; i++) { + regval = IXGBE_READ_REG(hw, IXGBE_DCA_TXCTRL_82599(i)); + regval |= IXGBE_DCA_TXCTRL_DESC_WRO_EN; + IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(i), regval); + } + + for (i = 0; i < hw->mac.max_rx_queues; i++) { + regval = IXGBE_READ_REG(hw, IXGBE_DCA_RXCTRL(i)); + regval |= (IXGBE_DCA_RXCTRL_DATA_WRO_EN | + IXGBE_DCA_RXCTRL_HEAD_WRO_EN); + IXGBE_WRITE_REG(hw, IXGBE_DCA_RXCTRL(i), regval); + } +} + /** * ixgbe_init_hw_generic - Generic hardware initialization * @hw: pointer to hardware structure diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h index 8cfadcb..c399c18 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h @@ -37,6 +37,7 @@ s32 ixgbe_init_ops_generic(struct ixgbe_hw *hw); s32 ixgbe_init_hw_generic(struct ixgbe_hw *hw); s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw); s32 ixgbe_start_hw_gen2(struct ixgbe_hw *hw); +void ixgbe_enable_relaxed_ordering(struct ixgbe_hw *hw); s32 ixgbe_clear_hw_cntrs_generic(struct ixgbe_hw *hw); s32 ixgbe_read_pba_string_generic(struct ixgbe_hw *hw, u8 *pba_num, u32 pba_num_size); diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 2ed2c7d..e97c89c 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -4898,6 +4898,7 @@ void ixgbe_reset(struct ixgbe_adapter *adapter) if (test_bit(__IXGBE_PTP_RUNNING, &adapter->state)) ixgbe_ptp_reset(adapter); + ixgbe_enable_relaxed_ordering(hw); } /** @@ -8470,6 +8471,7 @@ skip_sriov: "representative who provided you with this " "hardware.\n"); } + ixgbe_enable_relaxed_ordering(hw); strcpy(netdev->name, "eth%d"); err = register_netdev(netdev); if (err) _______________________________________________ Linux-nics mailing list Linux-nics@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
