Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 26 Nov 2014 20:13:09 +0100

> On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote:
>> wd819x should probably depend on VIRT_TO_BUS? But that means it will not work 
>> on sparc. Is there a way to make it work? I have a sparc machine but haven't 
>> tested it.
> 
> The explanation from Arnd in the other thread makes more sense -
> dma_cache_sync only is for non-coherent allocations so we should be
> able to remove it entirely.  Can you prepare and test a patch to just remove
> it for me?

Since dma_alloc_noncoherent is simply dma_alloc_coherent on sparc, I can
simply implement dma_cache_sync() as a nop.

I'll do that right now.

I also agree that if wd719x is not using dma_alloc_noncoherent(), it
should not be calling dma_cache_sync().
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux