Re: [PATCH V2] sparc64: sparse irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bob Picco <bpicco@xxxxxxxxxx>
Date: Tue, 16 Sep 2014 09:25:26 -0400

> 1) provides the option to enable SPARSE_IRQ

You're converting sparc64 completely over to SPARSE_IRQ unconditionally,
so this wording doesn't make any sense.  Please adjust the rest of
the commit message as needed.

> -#define NR_IRQS    255
> +#ifdef CONFIG_SPARSE_IRQ
> +#define NR_IRQS		(2048)
> +#else
> +#define NR_IRQS		(255)
> +#endif /* CONFIG_SPARSE_IRQ */

And thus SPARSE_IRQ checks no longer make any sense in sparc64 specific
files such as irq_64.h here.

> +#ifdef CONFIG_SPARSE_IRQ
> +unsigned int irq_alloc(unsigned int dev_handle, unsigned int dev_ino);
> +void irq_free(unsigned int irq);

Likewise throughout the rest of your patch.

You're really close, please fix this up and resubmit. :-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux