Re: q about ldc_bind after irq save

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (09/12/14 16:36), David Miller wrote:
> 
> > But is there a reason we can't move the request_irq from ldc_bind
> > and into ldc_alloc itself?  Or is there a simpler fix?
> 
> Because we don't have the string name for the IRQ until we get it
> from the ldc_bind() call, for one.

but that's not insurmountable. The name used by vnet/vdc is vio->name
(initialized in vio_driver_init(), before ldc_alloc() is called),
and ds uses a const string. So, by passing an extra const char *name
argument to ldc_alloc(), the request_irq()s  can be moved out of ldc_bind(),
avoiding the lockdep warning?

I'll submit a patch for this later today/tomorrow, unless there's
something else I'm missing.

--Sowmini



--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux