From: Bob Picco <bpicco@xxxxxxxxxx>
Date: Sun, 7 Sep 2014 11:49:49 -0400
> From: bob picco <bpicco@xxxxxxxxxx>
>
> The T5 (niagara5) has different PCR related HV fast trap values and a new
> HV API Group. This patch utilizes these and shares when possible with niagara4.
>
> We use the same sparc_pmu niagara4_pmu. Should there be new effort to
> obtain the MCU perf statistics then this would have to be changed.
>
> Cc: sparclinux@xxxxxxxxxxxxxxx
> Signed-off-by: Bob Picco <bob.picco@xxxxxxxxxx>
This patch looks fine but needs some minor coding style fixups.
> +unsigned long sun4v_t5_get_perfreg(unsigned long reg_num,
> + unsigned long *reg_val);
Arguments on the second and subsequent line of a function declaration
or call need to start exactly at the first column after the openning
parenthesis of the first line. You must use the appropriate number
of TAB and SPACE characters necessary to achieve this.
> - if (sun4v_hvapi_register(perf_hsvc_group,
> + hverror = sun4v_hvapi_register(perf_hsvc_group,
> perf_hsvc_major,
Since you are changing where the openning parenthesis of this function
call is located, you have to reindent the following lines as needed.
> + pr_err("perfmon: Could not register hvapi(0x%lx).\n",
> + hverror);
Not a blocker for this patch, but we probably want an "hverr_to_string()"
helper function so that we can print these out mnenomically.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
