From: Christopher Alexander Tobias Schulze <cat.schulze@xxxxxxxxxxxxx> Date: Sun, 3 Aug 2014 16:01:53 +0200 > From: Christopher Alexander Tobias Schulze <cat.schulze@xxxxxxxxxxxxx> > > Fix detection of BREAK on sunsab serial console: BREAK detection was only > performed when there were also serial characters received simultaneously. > To handle all BREAKs correctly, the check for BREAK and the corresponding > call to uart_handle_break() must also be done if count == 0, therefore > duplicate this code fragment and pull it out of the loop over the received > characters. > > Signed-off-by: Christopher Alexander Tobias Schulze <cat.schulze@xxxxxxxxxxxxx> Applied and queued up for -stable, thanks. But this function needs more work. For one thing, it needs to resample the status registers to update the stat->foo values each loop iteration, otherwise it will report break, overflow, etc. over and over again until we get the next interrupt. Serial chips seem to handle bare-break characters differently. The 8250 seems to indicate "data ready" in it's status register in such cases (and I suppose provides a zero character byte), whereas SAB seems to not put any bytes in it's FIFO in this situation. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
