Hi Khalid.
Looks better now - thanks.
A few nits remaining.
Please fix and submit a v3 - then we will see if David approves.
Sam
> +/* mdesc_open() - Grab a reference to mdesc_handle when /dev/mdesc is
> + * opened. Hold this reference until /dev/mdesc is closed to ensure
> + * mdesc data structure is not released underneath us. Store the
> + * pointer to mdesc structure in private_data for read and seek to use
Please use one space between "*" and "text" - not a tab.
This is how it is done in the rest of the sparc code.
> + */
> +static int mdesc_open(struct inode *inode, struct file *file)
> {
> struct mdesc_handle *hp = mdesc_grab();
> - int err;
>
> if (!hp)
> return -ENODEV;
>
> - err = hp->handle_size;
> - if (len < hp->handle_size)
> - err = -EMSGSIZE;
> - else if (copy_to_user(buf, &hp->mdesc, hp->handle_size))
> - err = -EFAULT;
> - mdesc_release(hp);
> + file->private_data = hp;
> + return 0;
> +}
Personally I would add an empty line before the return.
But this is not something mandatory.
> +static loff_t mdesc_llseek(struct file *file, loff_t offset, int whence)
> +{
> + struct mdesc_handle *hp;
> +
> + switch (whence) {
> + case SEEK_CUR:
> + offset += file->f_pos;
> + break;
> + case SEEK_SET:
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + hp = file->private_data;
> + if (offset > hp->handle_size)
> + return -EINVAL;
> + else
> + file->f_pos = offset;
> + return offset;
> +}
Likewise regarning empty line.
> +
> +/* mdesc_close() - /dev/mdesc is being closed, release the reference to
> + * mdesc structure.
> + */
Tab => space
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
