> From: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> Date: Mon, 9 Jun 2014 19:21:43 -0400
> Subject: [PATCH] serial: sunsab: Test for no tx data on tx restart
>
> Commit 717f3bbab3c7628736ef738fdbf3d9a28578c26c,
> 'serial_core: Fix conditional start_tx on ring buffer not empty'
> exposes an incorrect assumption in sunsab's start_tx method; the
> tx ring buffer can, in fact, be empty when restarting tx when
> performing flow control.
>
> Test for empty tx ring buffer when in sunsab's start_tx method.
>
> Signed-off-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
Hi Peter.
Can you please take a look at sunzilog.c.
It looks like the same test is missing in sunzilog_start_tx():
} else {
struct circ_buf *xmit = &port->state->xmit;
writeb(xmit->buf[xmit->tail], &channel->data);
ZSDELAY();
ZS_WSYNC(channel);
xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
port->icount.tx++;
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
uart_write_wakeup(&up->port);
}
I did not review all drives - only a few sun drivers
and this was the only one that occured to me also
required this check.
I also noticed the typical pattern is:
if (uart_circ_empty(xmit) || uart_tx_stopped(port))
Should you use this pattern also in sunsab.c?
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
