Re: format string mismatch in arch/sparc/kernel/sysfs.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/18/2014 07:32 PM, Sam Ravnborg wrote:
> Hi Torlaf.
> 
>> I'm just wondering if the format mismatch error is intentionally left in the code or not :
>>
>> [arch/sparc/kernel/sysfs.c:154]: (warning) %ld in format string (no. 1) requires 'long *' but the argument type is 'unsigned long *'.
> 
> This is something we should fix.
patch will be send out soon.

> My gcc does not give this warning - how did you produce the warning above?
Well, I got it with cppcheck - a nifty tool for static code checkin. I
stumbled over it a while ago - it still under development ofc.

> Also we use -Werror on purpose to catch warnings so they get fixed - so
> your build should have errored out.
> 
great

> Do you care to send a patch so you get proper attribution.

> 
> 	Sam
> 


-- 
Toralf

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux