Re: [PATCH 09/10] sparc64: Add basic validations to {pud,pmd}_bad().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Thu, 1 May 2014 18:17:02 +0200

> It would had been self-documenting if the type is changed to
> phys_addr_t here.  But I see that we do not use phys_addr_t much
> (only one place) in sparc code today.

I wouldn't be against such a cleanup.

Code has been using "unsigned long" since the dawn of time, most of
this stuff was written before phys_addr_t got added.  And it was added
to handle 32-bit machines with larger than 32-bit physical addresses.

Technically sparc32 could theoretically need it, as it supports 36-bit
physical address in the srmmu PTEs.  But actually in practice it does
not, as only I/O devices get mapped into ares using those high bits.

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux