Re: [PATCH] sparc64: Normalize NMI watchdog logging and behavior.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Sun, 4 May 2014 09:04:37 +0200

> On Sun, May 04, 2014 at 01:27:10AM -0400, David Miller wrote:
>> 
>> Bring this code in line with the perf based generic NMI watchdog
>> in kernel/watchdog.c (which we should convert over to at some
>> point).
>> 
>> In particular, don't do anything super fancy when the watchdog
>> triggers, and specifically don't do a do_exit() which only makes
>> things worse.
> 
> It is always good when we can use more of the generic functionality.
> Should we do something remotely similar for sparc32?
> 
> It looks like the sun4m_nmi() function is also used for sun4d + leon,
> but I need to look again to make sure.

The sun4m NMI function is just for hard asynchronous errors, rather
than a periodic event generated by perf counters.

So it serves a different purpose, but it could use some cleanups
nonetheless.  I wrote that code when I was a coding cowboy of
sorts :-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux