From: Ethan Zhao <ethan.kernel@xxxxxxxxx> Date: Tue, 7 Jan 2014 17:31:17 +0800 > Has kmalloc() failure checking there, so it is unnecessary to allocate with > __GFP_NOFAIL flag that might block forever. > > Signed-off-by: Ethan Zhao <ethan.kernel@xxxxxxxxx> This allocation failing borders on catastrophic. The allocation failure handling is just for looks. This function is triggered when the firmware tells us that new cpus or other devices are available. This memory being allocated will hold the machine description that we traverse to find those new devices. If this allocation is allowed to fail, we will never have any way to get the notification again. It really is __GFP_NOFAIL and must succeed. I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
