From: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> Date: Wed, 17 Apr 2013 15:52:26 -0500 > + else if (nr < 17) { > + int i; > + unsigned long vaddr2; > + for(i = 0; i < nr; i+=2) { Order the local variables from longest line to shortest. Put an empty line between the last local variable and the first statement. "for" is C primitive, therefor you put a space between it and the openning parenthesis. > + vaddr2 = i + 1 < nr ? vaddrs[i + 1] : 0; > + smp_cross_call_masked(&xcall_flush_tlb_pending, > + ctx, vaddrs[i], vaddr2, > + mm_cpumask(mm)); > + } > + } else > + /* > + * At some point it is probably cheaper to flush the whole > + * context rather than make too many cross calls > + */ > + smp_cross_call_masked(&xcall_flush_tlb_mm, ctx, 0, 0, > mm_cpumask(mm)); > > + Format comments: /* Like * this. */ Multi-line basic blocks need to be enclosed in braces, even if it is more than one line because of comments. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html