2013/3/26 David Miller <davem@xxxxxxxxxxxxx>:
> From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Date: Sun, 24 Mar 2013 17:55:06 +0900
>
>> The size of bitmaps which is accessed by bitops must be a multiple of
>> the sizeof(long). So it would be better to use BITS_TO_LONGS() to
>> calculate the bitmap size although it always be a multiple of the
>> sizeof(long)
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
>
> Same objection as patch #2, fixing a non-bug.
I thought it wasn't bug, but I was confused with bits and bytes, now
I realize that bitmap_bits is not always a multiple of the BITS_PER_LONG.
Because the value is set as below:
bitmap_bits = srmmu_nocache_size >> SRMMU_NOCACHE_BITMAP_SHIFT;
srmmu_nocache_size is decided proportionally by the amount of system RAM
and it is rounded to a multiple of PAGE_SIZE. SRMMU_NOCACHE_BITMAP_SHIFT
is defined as (PAGE_SHIFT - 4). So it can only be said that bitmap_bits
is a multiple of 16.
So this patch (and patch 1/3) actually fix a bug. I'll update the commit
messages and resend only the patches that fixing bug.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
