Re: [PATCH 2/3] sparc/iommu: use BITS_TO_LONGS() to calculate bitmap size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Date: Sun, 24 Mar 2013 17:55:05 +0900

> The size of bitmaps which is accessed by bitops must be a multiple of
> the sizeof(long).  So it would be better to use BITS_TO_LONGS() to
> calculate the bitmap size although IOMMU_NPTES is a multiple of
> BITS_PER_LONG.
> 
> This also fixes typo in the comment for IOMMU_NPTES.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>

Again, I'd rather not fix non-bugs.

You've also corrupted the indentation of the prom_printf() calls,
the arguments to a function should line up with the first column
after the openning parenthesis of the function call.

It was correct before your patch, it will be wrong afterwards.

But I don't want to apply this patch anyways, so don't bother
resubmitting the fixed version.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux