Re: [PATCH]sparc32: Fix lost pte_present() state while mprotect() system call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Kirill Tkhai <tkhai@xxxxxxxxx>
Date: Mon, 25 Feb 2013 17:05:18 +0400

> Should we account none pages in pte_present instead of above like this?
> 
> static inline int srmmu_pte_present(pte_t pte)
> { return ((pte_val(pte) & SRMMU_ET_MASK) == SRMMU_ET_PTE) ||
>           ((pte_val(pte) & SRMMU_PAGE_NONE) == SRMMU_PAGE_NONE); }

No, I don't think that is what we should do.

Instead, we should use the SRMMU_NOREAD bit to encode SRMMU_PAGE_NONE
pte's.  Then you make SRMMU_PAGE_NONE set SRMMU_ET_PTE but also
SRMMU_NOREAD.

Then you'll need no changes at all to srmmu_pte_present() or
SRMMU_CHG_MASK.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux