>>> default y >>> +config GRPCI1 >> I see we do not do so with GRPCI2 - but please prefix >> all SPARC specific kconfig symbols with SPARC_ > I can only see SPARC_LED and SPARC_LEON in arch/sparc/Kconfig following that naming convention. > Would it be more correct to call it LEON_GRPCI1? I see there are some SUN_ and US3_ names. sparc is not a good example here :-( For the new architectures I have reviewed recently all their arch specific symbols has been prefixed with the abbreviated arch name. And sparc specific symbols we add shall follow the same rule. I may fix up the other sparc specific symbols one day too, but it is low on my todo list. On the other hand using the name SPARC_LEON_xxx is too specific. We already should know what it is from the SPARC_GRPCI part of the name. >> A follow-up patch that fixes GRPCI2 would be nice! > > I can do that, if we establish what is appropriate. Would be nice - so the GRPCI symbols has consistent names. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
