Hi Michal, On 01/17/2013 09:05 PM, Michal Hocko wrote: > On Thu 17-01-13 18:37:10, Lin Feng wrote: > [...] >>> > > I am still not sure I understand the relation to MEMORY_HOTREMOVE. >>> > > Is register_page_bootmem_info_node required/helpful even if >>> > > !CONFIG_MEMORY_HOTREMOVE? >> > From old kenrel's view register_page_bootmem_info_node() is defined in >> > CONFIG_MEMORY_HOTPLUG_SPARSE, it registers some info for >> > memory hotplug/remove. If we don't use MEMORY_HOTPLUG feature, this >> > function is empty, we don't need the info at all. >> > So this info is not required/helpful if !CONFIG_MEMORY_HOTREMOVE. > OK, then I suggest moving it under CONFIG_MEMORY_HOTREMOVE guards rather > than CONFIG_MEMORY_HOTPLUG. I can't agree more ;-) I also find that page_isolation.c selected by MEMORY_ISOLATION under MEMORY_HOTPLUG is also such case, I fix it by the way. thanks, linfeng > -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
