Re: [PATCH] sparc64: exit_group should kill register windows just like plain exit.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Mon, 3 Dec 2012 19:35:58 +0000

> On Mon, Dec 03, 2012 at 02:30:49PM -0500, David Miller wrote:
>> 
>> Reported-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>> ---
>>  arch/sparc/kernel/sys32.S      |  2 +-
>>  arch/sparc/kernel/syscalls.S   | 14 ++++++++++++--
>>  arch/sparc/kernel/systbls_64.S |  2 +-
>>  3 files changed, 14 insertions(+), 4 deletions(-)
>> 
>> diff --git a/arch/sparc/kernel/sys32.S b/arch/sparc/kernel/sys32.S
>> index 44025f4..8475a47 100644
>> --- a/arch/sparc/kernel/sys32.S
>> +++ b/arch/sparc/kernel/sys32.S
>> @@ -47,7 +47,7 @@ STUB:	sra	REG1, 0, REG1; \
>>  	sra	REG4, 0, REG4
>>  
>>  SIGN1(sys32_exit, sparc_exit, %o0)
>> -SIGN1(sys32_exit_group, sys_exit_group, %o0)
>> +SIGN1(sys32_exit_group, sparc_exit_group, %o0)
> 
> No need of that part, really.  sys_exit_group() will have its argument
> (int) normalized all by itself.  The same goes for sys_exit(), so
> sys32_exit is also pointless; just have sparc_exit/sparc_exit_group in
> 32bit syscall table, same as you do in 64bit one...

As we've discussed in other thread, much of sys32.S is irrelevant.  I'll
try to find some time to audit the whole file and take care of all of
the extraneous cases in the sparc-next tree.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux