>
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index 6026fdd..d58edf5 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> +
> +void __meminit vmemmap_populate_print_last(void)
> +{
> + if (addr_start) {
> + printk(KERN_DEBUG " [%lx-%lx] on node %d\n",
> + addr_start, addr_end-1, node_start);
> + addr_start = 0;
> + addr_end = 0;
> + node_start = 0;
> + }
> +}
This confused me... I saw you added a function whích was never used.
include/linux/mm.h had a protoype with no comments at all !?!?
But then I could see we have a weak version defined in mm/
and you just add the arch version which overrides the waeak version.
A small comment would have helped me here.
But on the other hand you followed the comment style for this anyway :-(
Sam - going to grab some coffe to be less grumble
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
