Re: [sparc32]srmmu.c: BUG of srmmu_pte_clear optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kirill.

On Wed, May 30, 2012 at 01:27:12PM +0400, Kirill Tkhai wrote:
> The function srmmu_pmd_clear() is optimized by the following line:
> 
> BTFIXUPSET_CALL(pmd_clear, srmmu_pmd_clear, BTFIXUPCALL_SWAPO0G0);
> 
> It's wrong, because srmmu_pmd_clear(pmd_t *pmdp) can contain up to 16 pmdp->pmdv pointers, which must be cleared,
> but BTFIXUPCALL_SWAPO0G0 clears only one of them.
> 
> So, it's necessary to use BTFIXUPCALL_NORM instruction.

Ilya Malakhov <ilmalakhovthefirst@xxxxxxxxx> already reported this the other day.
In upstream this is "fixed" because we got rid of all the btfixup stuff.

If we want this fixed in stable then one of you guys needs to submit a
tested patch so we can apply this to stable.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux