On Sun, May 13, 2012 at 05:01:34PM -0400, David Miller wrote: > > This set of changes displays one major danger of btfixup, interface > signatures are not always type checked fully. As seen here the iounit > variant of the map_dma_area routine had an incorrect type for one of > it's arguments. > > It turns out to be harmless in this case, but just imagine trying to > debug something involving this kind of problem. No thanks. I found something similar for switch_mm(). It was an unused extra argument - so harmless too. I like the _ops variants much better than any run-time patching also for the readability. When you see an _ops structure you know what to look for. Are we going for _ops for everything? Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
