Re: [PATCH 1/8] KEYS: Use the compat keyctl() syscall wrapper on Sparc64 for Sparc32 compat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 11 May 2012 11:43:12 +0100

> Use the 32-bit compat keyctl() syscall wrapper on Sparc64 for Sparc32 binary
> compatibility.
> 
> Without this, keyctl(KEYCTL_INSTANTIATE_IOV) is liable to malfunction as it
> uses an iovec array read from userspace - though the kernel should survive this
> as it checks pointers and sizes anyway.
> 
> I think all the other keyctl() function should just work, provided (a) the top
> 32-bits of each 64-bit argument register are cleared prior to invoking the
> syscall routine, and the 32-bit address space is right at the 0-end of the
> 64-bit address space.  Most of the arguments are 32-bit anyway, and so for
> those clearing is not required.
> 
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx

I'm happy with someone else merging this in, thanks for doing this work:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux