From: Sam Ravnborg <sam@xxxxxxxxxxxx> Date: Fri, 27 Apr 2012 19:27:50 +0200 > This assignment looks redundant. I cannot see any uses of max_mapnr > in the kernel (which is relevant for sparc64). pfn_valid() via asm-generic/page.h > Knowing that sparc64 just got converted to NO_BOOTMEM it > hurts my eyes to see memblock_alloc() be replaced > by __alloc_bootmem_node(). Since the stack allocations happen now (for the sake of setting up the NUMA mappings) after bootmem init, it's prudent to use the alloc_bootmem interfaces. Not only visually, but syntactically as it provides: 1) fallbacks to non-NUMA allocations when NUMA node specific allocations fail. 2) a virtual pointer to zero'd memory so we don't need that __va() and memset crap -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html