Re: [PATCH] sparc: fix compile failure in kgdb_64.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 30, 2012 at 03:31:24PM -0400, Paul Gortmaker wrote:
> To fix:
> 
>   CC      arch/sparc/kernel/kgdb_64.o
>  arch/sparc/kernel/kgdb_64.c: In function 'smp_kgdb_capture_client':
>  arch/sparc/kernel/kgdb_64.c:121: error: implicit declaration of function 'flushw_all'
>  make[2]: *** [arch/sparc/kernel/kgdb_64.o] Error 1
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> 
> [tested on linux-next; presumably caused by the asm/system.h split]
> 
> diff --git a/arch/sparc/kernel/kgdb_64.c b/arch/sparc/kernel/kgdb_64.c
> index 768290a..e916169 100644
> --- a/arch/sparc/kernel/kgdb_64.c
> +++ b/arch/sparc/kernel/kgdb_64.c
> @@ -8,6 +8,7 @@
>  #include <linux/ftrace.h>
>  
>  #include <asm/kdebug.h>
> +#include <asm/cacheflush.h>
>  #include <asm/ptrace.h>
>  #include <asm/irq.h>

David already fixed this in the sparc tree and sent a pull request to Linus.
You can see his patch here:
https://git.kernel.org/?p=linux/kernel/git/davem/sparc.git;a=commitdiff;h=8befc9f23c695395de011ced289c611fada22f35

Please note a small difference...
The include is placed in the top to maintain the "inverse christmas tree" order.
Longest includes first - and these with equal length are sorted alphabetically.

This is used for all new sparc code.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux