From: Kautuk Consul <consul.kautuk@xxxxxxxxx>
Date: Mon, 26 Mar 2012 11:33:17 -0400
> + fault = handle_mm_fault(mm, vma, address,
> + flags | ((fault_code & FAULT_CODE_WRITE) ?
> + FAULT_FLAG_WRITE : 0);
This is so shockingly gross I'm at a loss for words. Why are you
tabbing this crap all the way into outer-space?
Make the "flags | ..." line up with the first column after the
openning parenthesis of "handle_mm_fault(".
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
> + 1, regs, address);
Same problem.
> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
> + 1, regs, address);
Same problem.
You're making the coding style worse each iteration, not better.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
