Re: [PATCH 3/4] sparc32: return destination pointer on return from memcpy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Konrad Eisele <konrad@xxxxxxxxxxx>
Date: Thu, 13 Oct 2011 09:00:04 +0200

> -/* In kernel these functions don't return a value.
> - * One should use macros in asm/string.h for that purpose.
> - * We return 0, so that bugs are more apparent.
> - */
> -#define SETUP_RETL
> -#define RETL_INSN	clr	%o0
> +#define SETUP_RETL	mov	%o0, %g6
> +#define RETL_INSN	mov	%g6, %o0

Sigh...

The kernel uses %g6 as the global thread register, see
include/asm/thread_info_32.h:

register struct thread_info *current_thread_info_reg asm("g6");

Your kernel would have crashed early in the boot if you actually
tested this patch.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux