Re: [PATCH 3/4] sparc32,leon: Add support for KGDB when SMP and SPARC_LEON is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Konrad,

Another minor comment:

On Fri, Sep 30, 2011 at 21:24, Konrad Eisele <konrad@xxxxxxxxxxx> wrote:
> diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
> index a11db95..380753e 100644
> --- a/kernel/debug/gdbstub.c
> +++ b/kernel/debug/gdbstub.c
> @@ -946,7 +946,8 @@ int gdb_serial_stub(struct kgdb_state *ks)
>                ptr = remcom_out_buffer;
>                *ptr++ = 'T';
>                ptr = pack_hex_byte(ptr, ks->signo);
> -               ptr += strlen(strcpy(ptr, "thread:"));
> +               strcpy(ptr, "thread:");
> +               ptr += strlen(ptr);

This looks like it should go in a different patch.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux