Hi Ian. On Thu, Aug 18, 2011 at 11:05:48AM +0100, Ian Campbell wrote: > On Thu, 2011-08-18 at 10:49 +0100, Sam Ravnborg wrote: > > On Thu, Aug 18, 2011 at 10:25:15AM +0100, Ian Campbell wrote: > > > On Thu, 2011-08-18 at 09:59 +0100, David Miller wrote: > > > > From: Ian Campbell <ian.campbell@xxxxxxxxxx> > > > > Date: Thu, 18 Aug 2011 09:14:57 +0100 > > > > > > > > >>From a sparc64 defconfig: > > > > > CC arch/sparc/kernel/pcic.o > > > > > > > > A sparc64 defconfig? This is code only built for 32-bit sparc :-) > > > > > > My local script confused me, it translated sparc64 into ARCH=sparc for > > > me, where it turns out the defconfig == sparc32_defconfig, so I was > > > actually building 32 bit. Sorry about that. > > > > > > Turns out I also saw this on 32-bit sparc defconfig, which is hardly > > > surprising given the two .configs are exactly the same ;-) > > sparse complains too - I just never got around to fix it up. > > > > If you do nto beat me I will look at it soon. Somehow I missed that you already had provided a patch in the first mail. this patch has my: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > With my patch applied I don't see any sparse warnings for these lines of > pcic.c, although there are others: > CHECK /local/scratch/ianc/devel/kernels/linux-2.6/arch/sparc/kernel/pcic.c > arch/sparc/kernel/pcic.c:163:14: warning: symbol 'pcic_regs' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:164:14: warning: symbol 'pcic_speculative' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:165:14: warning: symbol 'pcic_trapped' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:331:66: warning: Using plain integer as NULL pointer > arch/sparc/kernel/pcic.c:343:66: warning: Using plain integer as NULL pointer > arch/sparc/kernel/pcic.c:539:38: warning: Using plain integer as NULL pointer > arch/sparc/kernel/pcic.c:677:1: warning: symbol 'pcic_pin_to_irq' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:718:5: warning: symbol 'pci_gettimeoffset' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:787:6: warning: symbol 'pcic_nmi' was not declared. Should it be static? > arch/sparc/kernel/pcic.c:883:5: warning: symbol 'pcibios_assign_resource' was not declared. Should it be static? > CC arch/sparc/kernel/pcic.oA Trivial stuff - mostly missing extern stuff. But we should kill these warnings soon so they do not hide more serious warnings. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
