Re: [PATCH 4/4] sparc32: genirq conversion (buggy)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Sun, 13 Feb 2011 20:29:52 +0100

> +unsigned int irq_alloc(unsigned int real_irq, unsigned int pil)
> +{
> +	unsigned int i;
 ...
> +	for (i = 1; i < NR_IRQS; i++) {
> +		if (irq_table[i].irq == real_irq && irq_table[i].irq == pil)
> +			return i;
> +	}
 ...
> +	irq_table[i].irq = i;
> +	irq_table[i].pil = pil;
> +
> +	return i;
> +}

Well, what is it?  Are we storing "real_irq" in irq_table[].irq or
"i"?  I think it's supposed to be "real_irq" and that's one of the
reasons your implementation isn't working :-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux