I am slowly working towards the goal of migrating
sparc32 to genirq.
PArt of the job is to understand the current code-base.
While reading the code I was constantly distracted
by all the minor issues in these.
So I cooked up a few patches to clean up the files.
In general I did like this:
- Manually identified headers that was not needed
- Added comments from an old patch from davem
- Read through the file and fixed all the obvious stuff
- Ran checkpatch on each file and fixed what I considered relevant
The files does not pass checkpatch with no warnings - this
was not my goal.
But the readability has increased which is good.
Changes in v2:
- rebased on top of sparc-next
- included patch to clean up irq_32.c
To build a sparc32 allnoconfig a merge of mainline is required.
This is a bug introduced in mainline and is not
the resuts of these cleanups. So the merge is not strictly required.
But it would be good for my further work if you will
merge -rc3 when it is tagged.
Then I will implicitly also test the new stuff in rc3 a bit.
There are no (intended) functional changes introduced.
Patchset has received light test on my SPARCclassic box.
[boots and my shell behaves as before]
Please consider applying.
Thanks,
Sam
Sam Ravnborg (8):
sparc32: remove tick14.c
sparc32: add irq + smp declarations to headers
sparc32,sun4c: irq file cleanup
sparc32,sun4m: irq, smp files cleanup
sparc32,sun4d: irq, smp files cleanup
sparc32,sun4d: drop unused code in sun4d_distribute_irqs()
sparc32,sun4d: add comment in empty statement in sun4d_request_irq()
sparc32: irq_32.c cleanup
arch/sparc/include/asm/mmu_32.h | 3 +
arch/sparc/include/asm/smp_32.h | 6 +
arch/sparc/kernel/Makefile | 1 -
arch/sparc/kernel/irq_32.c | 235 ++++++++++++++++-----------------------
arch/sparc/kernel/kernel.h | 47 ++++++++
arch/sparc/kernel/setup_32.c | 19 ++--
arch/sparc/kernel/sun4c_irq.c | 81 +++++++------
arch/sparc/kernel/sun4d_irq.c | 227 +++++++++++++++++---------------------
arch/sparc/kernel/sun4d_smp.c | 176 +++++++++++------------------
arch/sparc/kernel/sun4m_irq.c | 182 +++++++++++++++---------------
arch/sparc/kernel/sun4m_smp.c | 91 ++++------------
arch/sparc/kernel/tick14.c | 39 -------
arch/sparc/prom/misc_32.c | 4 -
13 files changed, 486 insertions(+), 625 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
