From: Sam Ravnborg <sam@xxxxxxxxxxxx> Date: Thu, 27 Jan 2011 20:36:03 +0100 > If we want to be more explicit we can do: > > u32 psr; > > psr = get_psr(); > psr_impl = (psr & PSR_IMPL) >> PSR_IMPL_SHIFT; > > I assume gcc will generate equal code for this. > But this looks like overkill. > > The mixed use of unsigned int and int in this file also looks > like something to be cleaned up... Daniel, please respin your patch so that we explicitly use unsigned variables here as Sam suggests, and thus avoid the sign-extension issues during the right-shift operations. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
