Re: [PATCH 5/5] sparc64: use up-to-data genirq functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Josip Rodin <joy@xxxxxxxxxxxxxx>
Date: Sat, 22 Jan 2011 00:43:44 +0100

> On Fri, Jan 21, 2011 at 11:26:56PM +0100, Sam Ravnborg wrote:
>> Drop all uses of deprecated genirq features
> 
>> -static int sun4u_set_affinity(unsigned int virt_irq,
>> -			       const struct cpumask *mask)
>> +static int sun4u_set_affinity(struct irq_data *data,
>> +			       const struct cpumask *mask, bool force)
>> -static int sun4v_set_affinity(unsigned int virt_irq,
>> -			       const struct cpumask *mask)
>> +static int sun4v_set_affinity(struct irq_data *data,
>> +			       const struct cpumask *mask, bool force)
>> -static int sun4v_virt_set_affinity(unsigned int virt_irq,
>> -				    const struct cpumask *mask)
>> +static int sun4v_virt_set_affinity(struct irq_data *data,
>> +				    const struct cpumask *mask, bool force)
> 
> For the benefit of future readers, maybe add a short comment to the commit
> description to explain why these functions are now apparently ignoring the
> 'force' parameter, that is, does it not apply because it's not presently
> implemented, or because it just doesn't make sense.

I don't see any implementation where the "force" parameter is used, and
I see no call of these methods that every sets "force" to anything other
than "false".
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux