On Tue, Jan 18, 2011 at 10:25:24AM +0100, Kristoffer Glembo wrote:
> Hi,
>
>
> Sam Ravnborg wrote:
> >
> > I have failed to see what is the difference between pci32_alloc_coherent()
> > and the LEON variant of sbus_alloc_coherent().
>
> Yes the only difference it the setting of the name in the resource. Maybe it does not warrant the messy code.
>
> >
> > Likewise for this. It looks equal to pci32_free_coherent().
> >
>
> Yes this case is actually totally equal.
>
> For me it is no problem using the pci versions. I tried using the sbus versions on advice from Dave but maybe it was not very successful :)
>
>
> > Please investigate if you can use pci32_unmap_sg.
> > If this is the case you can reuse pci32_dma_ops direct.
> > As you can use pci32_map_sg() I would assume you can also
> > use the counterpart for unmap..
> >
>
> Yes I can remove it. It was pretty unnecessary.
I look forward for next version.
Note: I review this with only limited knowledge of the DMA stuff etc.
So you shall (as always) treat the input as such.
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
