Re: [PATCH 2/4 V2] sparc: Add pci32_unmap_page.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

Sorry for my sluggish replies.

Sam Ravnborg wrote:
> On Thu, Jan 13, 2011 at 10:05:33AM +0100, Kristoffer Glembo wrote:
>> Signed-off-by: Kristoffer Glembo <kristoffer@xxxxxxxxxxx>
> 
> I totally miss _why_ you add this function.
> Just a small comment in the changelog would help.
> It may due to my ignorance of all the dma stuff...
> 


It is part of the DMA API and needed by our ethernet driver. I guess no PCI driver (on sparc) used it before.


> 
> How about a patch that fix it so mmu_inval_dma_area() takes a void *
> as first argument?
> In most cases I see a cast from void * => unsigned long where we call
> mmu_inval_dma_area().
> 


Ok.


/Kristoffer
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux