Re: [PATCH] sparc: explicitly cast negative phandle checks to s32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Grant Likely <grant.likely@xxxxxxxxxxxx>
Date: Mon, 3 Jan 2011 19:26:38 -0700

> On Thu, Nov 11, 2010 at 10:42:06PM -0800, Andres Salomon wrote:
>> 
>> When we switched sparc from using 'int's to 'phandle's (which is a u32), we
>> neglected to do anything with the various checks for -1.  For those tests,
>> explicitly cast the phandles to s32.
>> 
>> My sparc machine is down, so I was unable to build-test this..
>> 
>> Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> 
> Two hunks in this patch no longer apply as the code it touches appears
> to have been removed, but the rest applies and at least compiles.  I
> haven't boot tested it though.
> 
> Dave, I imagine this fix should go in via your tree, but I can pick it
> up if you prefer.
> 
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

Indeed, I was hoping you would pick it up Grant, thanks :-)

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux