On Sun, Jan 2, 2011 at 07:57, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > I decided to complete the unification of piggyback. > This was inspired by comments from Julian Calaby. =) > The patchset documents my findings while reverse engineering > piggyback. And some limited refactoring also increased > readability a lot. > piggyback now takes an argument that tell if this is for > sparc or sparc64 and uses this info to adjust behaviour > as sparc and sparc64 differs in a few places. > > With these additions we can now use the same piggyback for > both sparc and sparc64. Yay! > My testing turned out that piggyback_64 was broken on my x86 box, > because it was hardcoded to assume a big-endian host. > I also found a few code-spots that assuemd the host was big-endian. > All cases are fixed to be endian neutral. > > Julian Calaby acknowledged that piggyback_64 had endian troubles. Well, in as much as it'd never been fixed like _32 had. > This is boot tested on my sparc box. > I have only build tested the sparc64 bits! I'll try to get my box running in the near future and give you an update on this. That said, I know that my old endian fixed version of piggyback_64 works, so I'll do a quick check first to ensure that your version produces the same output. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
