On Mon, Dec 13, 2010 at 09:46, David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Julian Calaby <julian.calaby@xxxxxxxxx> > Date: Sat, 04 Dec 2010 14:57:47 +1100 > >> prom_console_write_buf() is only used in prom/printf.c, so as it's >> the only remaining function in console_*.c, let's merge console_*.c >> into printf.c. >> >> We'll also rename prom_nbputchar() to __prom_console_write_buf() >> and merge the definitions of prom_console_write_buf() as they're >> identical. >> >> Signed-off-by: Julian Calaby <julian.calaby@xxxxxxxxx> > > This doesn't make sense. > > The whole idea is that when there is a 32-bit and 64-bit implementation > of the same interface, we have foo_32.c and foo_64.c to implement > them which is exactly what is happening here. Fair enough. The reason for these changes were that I feel that having two files for one function is a little excessive - hence this move. But that said, #ifdefs are also evil. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
