On Mon, 2010-09-13 at 21:36 +0100, Alan Cox wrote: > On Mon, 13 Sep 2010 12:47:56 -0700 > Joe Perches <joe@xxxxxxxxxxx> wrote: > > diff --git a/drivers/serial/suncore.c b/drivers/serial/suncore.c > > @@ -106,7 +106,7 @@ void sunserial_console_termios(struct console *con, struct device_node *uart_dp) > > if (of_console_options) > > c = *of_console_options; > > > > - mode_prop[3] = c; > > + sprintf(mode_prop, "tty%c-mode", c); > Whats the point of all this. It's trivial code being replaced by > something complicated, harder to understand and much slower ? There are many cases of char foo[] = "bar" that should be actually be [static] const char foo[] etc. The patch set was done to change those cases. This case isn't actually any sort of saving. As I just wrote in 5/25 to Jonathan Cameron: It tries to standardize the style use and it avoids possible future checkpatch warnings of: char foo[] = "bar" char array could possibly be static const. There was another use with "%1.1d" somewhere. The end result is the same, so I don't really care much if this sort of change is applied or not. The possible checkpatch message could just be considered noise but Mike Frysinger seemed to prefer it, so I thought I could try to accommodate him. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
