The function su_probe in the file drivers/serial/sunsu.c contains the
code:
if (up->su_type == SU_PORT_KBD || up->su_type == SU_PORT_MS) {
err = sunsu_kbd_ms_init(up);
if (err) {
kfree(up);
goto out_unmap;
}
dev_set_drvdata(&op->dev, up);
return 0;
}
And then the label out_unmap contains:
out_unmap:
of_iounmap(&op->resource[0], up->port.membase, up->reg_size);
return err;
which represents a potential use of up after the free. There are however
other gotos to out_unmap that don't seem to want to free up. Should the
of_iounmap just be copied up before the kfree(up)?
julia
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
