Re: [PATCH 1/2] sparc: us3_cpufreq.c: fix warnings/errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 21, 2009 at 12:14:11PM -0800, David Miller wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date: Mon, 21 Dec 2009 20:59:21 +0100
> 
> > As the comment says:
> > "Don't use BUG() or BUG_ON() unless there's really no way out;"
> > 
> > I would have expected to see something like this:
> > #define BUG() do {} while(1)
> 
> Maybe we can use "unreachable()" here.
Makes sense.

Alexander - could you please try to add an
unreachable() call in in bug.h and if it
kills the warnings as expected then send
a patch to Arnd including a proper
changelog describing why this was need.

I copied Arnd on this mail albeit he may miss some context...
In short - Alexandar posted a few patches to get rid of
a set of warnings on sparc.
The root cause of the warnings was the definition of
BUG() when CONFIG_BUG is not set.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux