On Wed, Nov 25, 2009 at 9:04 PM, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2009-11-24 at 01:19 -0700, Grant Likely wrote: >> /** >> + * early_init_move_devtree - move tree to an unused area, if needed. >> + * >> + * The device tree may be allocated beyond our memory limit, or inside the >> + * crash kernel region for kdump. If so, move it out of the way. >> + */ >> +#if defined(CONFIG_PPC) >> +static void __init early_init_move_devtree(void) > > And you still end up with an ifdef mess in the common code ... The #ifdefs are temporary. I'm leaving them in now exactly because they are ugly and show where the code needs to be refactored and reorganized. Once everything is merged, I'll probably do exactly what you suggest. I just cannot yet tell the exact structure of it until I see the merged version. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html