Re: [PATCH 1/2] Added sparc_leon3_snooping_enabled()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Kristoffer Glembo <kristoffer@xxxxxxxxxxx>
Date: Mon,  2 Nov 2009 15:28:11 +0100

> Added a function for checking if snooping is enabled.

You need to provide a proper "Signed-off-by:" when submitting patches.

Also, all of these inline routines in leon.h should be
"static inline" not "extern inline".

"extern inline" tells the compiler that it can choose to not
inline the function, and that externally in some other object
file an implementation of that function will exist that the
compiler can generate a call to.

You want "static inline" which tells the compiler that it either
must inline the function or emit a local static copy of it into
the current compilation unit.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux