From: Julian Calaby <julian.calaby@xxxxxxxxx> Date: Wed, 4 Nov 2009 09:48:20 +1100 > On Tue, Nov 3, 2009 at 01:48, Kristoffer Glembo <kristoffer@xxxxxxxxxxx> wrote: >> This patch adds support for the APBUART serial port from Aeroflex >> Gaisler's IP library GRLIB. It is currently used in all LEON3 designs >> (SPARC V8) but can be used on other platforms as well. > [snip] >> +config SERIAL_GRLIB_GAISLER_APBUART >> + tristate "GRLIB APBUART serial support" >> + depends on SPARC_LEON >> + ---help--- >> + Add support for the GRLIB APBUART serial port. >> + > > Shouldn't it then depend on OpenFirmware rather than SPARC_LEON? Yeah it probably should unless there are real dependencies on LEON specific functions, which I don't think this serial driver does. Using "OF" as the dependency would be great for me because then I'd be able to test the build on this even on sparc64. :-) So Kristoffer, please make this change and resubmit your patch. The driver looks fine to me otherwise. Thanks! -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
