Re: page_to_phys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Kristoffer Glembo <kristoffer@xxxxxxxxxxx>
Date: Fri, 09 Oct 2009 16:02:14 +0200

> Currently in io_32.h page_to_phys is defined as:
> 
> #define page_to_phys(page)	(((page) - mem_map) << PAGE_SHIFT)
> 
> Should it not be:
> 
> #define page_to_phys(page) ((((page) - mem_map) << PAGE_SHIFT) +
> #phys_base)
> 
> or perhaps:
> 
> #define page_to_phys(page) ((dma_addr_t)page_to_pfn(page) <<
> #PAGE_SHIFT)

Sparc 32-bit doesn't offset the mem_map at phys_base.

What is offset by phys_base is what gets mapped at PAGE_OFFSET
virtually.

That's why the things that translate between virtual and physical
addresses do take phys_base into account.

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux